Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21804#discussion_r203656238 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/AbstractDataType.scala --- @@ -145,7 +145,7 @@ abstract class NumericType extends AtomicType { } -private[sql] object NumericType extends AbstractDataType { +private[spark] object NumericType extends AbstractDataType { --- End diff -- I am fine changing them all to `private[spark]`. @gatorsmile @HyukjinKwon what do you think?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org