Github user zuotingbing commented on a diff in the pull request:
https://github.com/apache/spark/pull/21789#discussion_r203682086
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
---
@@ -766,6 +774,14 @@ class HiveThriftHttpServerSuite extends
HiveThriftJdbcTest {
assert(resultSet.getString(2) === HiveUtils.builtinHiveVersion)
}
}
+
+ test("Checks cast as float") {
--- End diff --
sorry i do not agree with you. HiveThriftBinaryServerSuite and
HiveThriftHttpServerSuite ,which have exist before, are different cases for
different ServerMode, we should test them all. if we add test in
HiveThriftJdbcTest , we need to set different ServerMode in HiveThriftJdbcTest
for the two cases, which break the design of abstract class of
HiveThriftJdbcTest .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
