Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21813#discussion_r203842450
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/ResolveGroupingAnalyticsSuite.scala
---
@@ -91,6 +91,40 @@ class ResolveGroupingAnalyticsSuite extends AnalysisTest
{
assertAnalysisError(originalPlan3, Seq("doesn't show up in the GROUP
BY list"))
}
+ test("grouping sets with no explicit group by expressions") {
+ val originalPlan = GroupingSets(Seq(Seq(), Seq(unresolved_a),
Seq(unresolved_a, unresolved_b)),
+ Nil, r1,
+ Seq(unresolved_a, unresolved_b,
UnresolvedAlias(count(unresolved_c))))
+ val expected = Aggregate(Seq(a, b, gid), Seq(a, b,
count(c).as("count(c)")),
+ Expand(
+ Seq(Seq(a, b, c, nulInt, nulStr, 3), Seq(a, b, c, a, nulStr, 1),
Seq(a, b, c, a, b, 0)),
+ Seq(a, b, c, a, b, gid),
+ Project(Seq(a, b, c, a.as("a"), b.as("b")), r1)))
+ checkAnalysis(originalPlan, expected)
+
+ val originalPlan2 = GroupingSets(Seq(Seq(), Seq(unresolved_a),
Seq(unresolved_a, unresolved_b)),
+ Nil, r1,
+ Seq(unresolved_a, unresolved_b,
UnresolvedAlias(count(unresolved_c))))
--- End diff --
hmm, I think `originalPlan2` looks the same as `originalPlan`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
