Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21118#discussion_r204028611
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala
---
@@ -53,7 +54,7 @@ class KafkaContinuousReader(
metadataPath: String,
initialOffsets: KafkaOffsetRangeLimit,
failOnDataLoss: Boolean)
- extends ContinuousReader with SupportsScanUnsafeRow with Logging {
--- End diff --
can we get rid of `KafkaRecordToUnsafeRowConverter`? Since Spark would do a
unsafe projection at the end, here we should just return `GenericInternalRow`
instead of `UnsafeRow`, to save data cpoy.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
