Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21822#discussion_r204163484
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -33,6 +49,116 @@ abstract class LogicalPlan
       with QueryPlanConstraints
       with Logging {
     
    +  private var _analyzed: Boolean = false
    +
    +  /**
    +   * Marks this plan as already analyzed. This should only be called by 
[[CheckAnalysis]].
    +   */
    +  private[catalyst] def setAnalyzed(): Unit = { _analyzed = true }
    +
    +  /**
    +   * Returns true if this node and its children have already been gone 
through analysis and
    +   * verification.  Note that this is only an optimization used to avoid 
analyzing trees that
    +   * have already been analyzed, and can be reset by transformations.
    +   */
    +  def analyzed: Boolean = _analyzed
    +
    +  /**
    +   * Returns a copy of this node where `rule` has been recursively applied 
first to all of its
    +   * children and then itself (post-order, bottom-up). When `rule` does 
not apply to a given node,
    +   * it is left unchanged.  This function is similar to `transformUp`, but 
skips sub-trees that
    +   * have already been marked as analyzed.
    +   *
    +   * @param rule the function use to transform this nodes children
    +   */
    +  def resolveOperators(rule: PartialFunction[LogicalPlan, LogicalPlan]): 
LogicalPlan = {
    --- End diff --
    
    todo: add unit tests


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to