GitHub user wangyum opened a pull request:

    https://github.com/apache/spark/pull/21863

    [SPARK-18874][SQL][FOLLOW-UP] Improvement type mismatched message

    ## What changes were proposed in this pull request?
    How to reproduce:
    ```sql
    create table test1(c1 double, c2 string, c3 string);
    create table test2(c1 decimal(18, 0), c2 string, c3 int);
    select * from test1 where (c1, c2, c3) in (select c1, c2, c3 from test2);
    ```
    Vanilla message:
    ```
    Mismatched columns:
    [(, t, e, s, t, 1, ., `, c, 1, `, :, d, o, u, b, l, e, ,,  , t, e, s, t, 2, 
., `, c, 1, `, :, d, e, c, i, m, a, l, (, 1, 8, ,, 0, ), ), (, t, e, s, t, 1, 
., `, c, 3, `, :, s, t, r, i, n, g, ,,  , t, e, s, t, 2, ., `, c, 3, `, :, i, 
n, t, )]
    ```
    After this patch:
    ```
    Mismatched columns:
    [(test1.`c1`:double, test2.`c1`:decimal(18,0)), (test1.`c3`:string, 
test2.`c3`:int)]
    ```
    
    ## How was this patch tested?
    
    manual tests


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangyum/spark SPARK-18874

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21863.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21863
    
----
commit e455bda5f62f9ce6805809b66482a93bec9d7956
Author: Yuming Wang <yumwang@...>
Date:   2018-07-24T15:36:37Z

    Improvement type mismatched message.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to