Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3103#issuecomment-61775156
@srowen Sorry for not being clear enough about the Guava stuff. So the
situation is, currently if you build Spark master branch (say
https://github.com/apache/spark/commit/c8abddc5164d8cf11cdede6ab3d5d1ea08028708)
with Maven, the META-INF/MANIFEST.MF file within the assembly jar is copied
from Guava 15.0, and doesn't contain legitimate information about Spark. That's
why I said this PR only adds implementation/specification fields to the Guava
manifest. Only Maven suffers from this issue, the SBT build is fine.
In SBT, we discard all MANIFEST.MF files in dependency jar files in the
assembly merge strategies, and it seems that SBT is able to generate a proper
MANIFEST.MF for the Spark assembly jar. However, if we [exclude MANIFEST.MF in
assembly/pom.xml](https://github.com/apache/spark/blob/c8abddc5164d8cf11cdede6ab3d5d1ea08028708/assembly/pom.xml#L120-L125),
no MANIFEST.MF is left in the assembly jar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
