Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21650#discussion_r205025755
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -5487,6 +5617,22 @@ def dummy_pandas_udf(df):
                                                      F.col('temp0.key') == 
F.col('temp1.key'))
             self.assertEquals(res.count(), 5)
     
    +    def test_mixed_scalar_udfs_followed_by_grouby_apply(self):
    +        # Test Pandas UDF and scalar Python UDF followed by groupby apply
    +        from pyspark.sql.functions import udf, pandas_udf, PandasUDFType
    +        import pandas as pd
    --- End diff --
    
    not a big deal at all really .. but I would swap the import order 
(thridparty, pyspark)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to