Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/3062#discussion_r19866949 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/export/pmml/PMMLModelExport.scala --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.mllib.export.pmml + +import java.text.SimpleDateFormat +import java.util.Date + +import scala.beans.BeanProperty + +import org.dmg.pmml.Application +import org.dmg.pmml.Header +import org.dmg.pmml.PMML +import org.dmg.pmml.Timestamp + +import org.apache.spark.mllib.export.ModelExport + +private[mllib] trait PMMLModelExport extends ModelExport{ + + /** + * Holder of the exported model in PMML format + */ + @BeanProperty + val pmml: PMML = new PMML(); + + setHeader(pmml); + + private def setHeader(pmml : PMML): Unit = { + val version = getClass().getPackage().getImplementationVersion() + val app = new Application().withName("Apache Spark MLlib").withVersion(version) + val timestamp = new Timestamp() + .withContent(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss").format(new Date())) + val header = new Header() + .withCopyright("Apache Spark MLlib") + .withApplication(app) + .withTimestamp(timestamp); + pmml.setHeader(header); + pmml.setVersion("4.2") --- End diff -- 4.2.1 is technically the latest version... although I don't know that we're using any features that require that version, I'd default to specifying the current latest version.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org