Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21878#discussion_r205346891
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -635,12 +637,6 @@ object DataSource extends Logging {
                         "Hive built-in ORC data source must be used with Hive 
support enabled. " +
                         "Please use the native ORC data source by setting 
'spark.sql.orc.impl' to " +
                         "'native'")
    -                } else if (provider1.toLowerCase(Locale.ROOT) == "avro" ||
    -                  provider1 == "com.databricks.spark.avro") {
    -                  throw new AnalysisException(
    --- End diff --
    
    Actually, I think it would be okay. If user provide `avro`, it will show an 
error like:
    
    ```
    17/05/10 09:47:44 WARN DataSource: Multiple sources found for csv 
(org.apache.spark.sql.execution.datasources.csv.CSVFileFormat,
    com.databricks.spark.csv.DefaultSource15), defaulting to the internal 
datasource (org.apache.spark.sql.execution.datasources.csv.CSVFileFormat).
    ```
    
    in most cases (see https://github.com/apache/spark/pull/17916)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to