Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21835#discussion_r205355152
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -3320,7 +3321,7 @@ setMethod("explode",
     #' @aliases sequence sequence,Column-method
     #' @note sequence since 2.4.0
     setMethod("sequence",
    -         signature(x = "Column", y = "Column"),
    +         signature(),
    --- End diff --
    
    this doesn't seem quite right-  we should be able to keep `signature(x = 
"Column", y = "Column"),` here


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to