Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/21880#discussion_r205470335
--- Diff: dev/merge_spark_pr.py ---
@@ -331,6 +331,9 @@ def choose_jira_assignee(issue, asf_jira):
assignee = asf_jira.user(raw_assignee)
asf_jira.assign_issue(issue.key, assignee.key)
return assignee
+ except KeyboardInterrupt:
+ traceback.print_exc()
+ sys.exit(-1)
--- End diff --
any reason to do this, rather than just
```
except KeyboardInterrupt:
raise
except:
...
```
? That seems to do the right thing in a small test I tried, letting you
break out of the loop:
```
while True:
try:
x = raw_input("enter a number: \n")
print int(x)
except KeyboardInterrupt:
raise
except:
print "oops, entered " + x
```
`sys.exit` makes it impossible for an wrapping function to do its own
handling.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
