Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/21847#discussion_r205550412 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala --- @@ -165,16 +183,100 @@ class AvroSerializer(rootCatalystType: DataType, rootAvroType: Schema, nullable: result } - private def resolveNullableType(avroType: Schema, nullable: Boolean): Schema = { - if (nullable) { + private def resolveNullableType(avroType: Schema, catalystType: DataType, --- End diff -- Not caused by this PR, but we better explain what this method does. Can you add a comment for it?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org