Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21850#discussion_r205830257
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
 ---
    @@ -414,6 +414,9 @@ object SimplifyConditionals extends Rule[LogicalPlan] 
with PredicateHelper {
             // these branches can be pruned away
             val (h, t) = branches.span(_._1 != TrueLiteral)
             CaseWhen( h :+ t.head, None)
    +
    +      case CaseWhen(Seq((cond, trueValue)), elseValue) =>
    +        If(cond, trueValue, elseValue.getOrElse(Literal(null, 
trueValue.dataType)))
    --- End diff --
    
    Let's revisit this PR later, and we should always try to add CASE WHEN 
version for parity. 
    
    Here is the one for case when.
    https://github.com/apache/spark/pull/21852


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to