Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3111#discussion_r19898831
  
    --- Diff: project/SparkBuild.scala ---
    @@ -353,8 +361,10 @@ object TestSettings {
           .map { case (k,v) => s"-D$k=$v" }.toSeq,
         javaOptions in Test ++= "-Xmx3g -XX:PermSize=128M -XX:MaxNewSize=256m 
-XX:MaxPermSize=1g"
           .split(" ").toSeq,
    +    javaOptions in Test += 
    --- End diff --
    
    This is so much nicer than it is in maven :P It would be good to add a 
comment here explaining what this is for.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to