Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20556#discussion_r205862781
--- Diff: dev/lint-python ---
@@ -82,6 +88,34 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# Check python document style, skip check if pydocstyle is not installed.
+if hash "$PYDOCSTYLEBUILD" 2> /dev/null; then
+ if [ "$PYDOCSTYLEVERSION">="$EXPECTED_PYDOCSTYLEVERSION" ]; then
+ pydocstyle --config=dev/tox.ini $DOC_PATHS_TO_CHECK >>
"$PYDOCSTYLE_REPORT_PATH"
+ pydocstyle_status="${PIPESTATUS[0]}"
+
+ if [ "$compile_status" -eq 0 -a "$pydocstyle_status" -eq 0 ]; then
+ lint_status=0
+ else
+ lint_status=1
+ fi
+
+ if [ "$lint_status" -ne 0 ]; then
+ echo "pydocstyle checks failed."
+ cat "$PYDOCSTYLE_REPORT_PATH"
+ rm "$PYDOCSTYLE_REPORT_PATH"
+ exit "$lint_status"
+ else
+ echo "pydocstyle checks passed."
+ rm "$PYDOCSTYLE_REPORT_PATH"
+ fi
+ else
+ echo "The pydocstyle version needs to be latest 2.1.1.Skipping
pydoc checks for now"
--- End diff --
nit: add a space between "2.1.1.Skipping" the final dot and skipping.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
