Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/3094#discussion_r19903935
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/configuration/Strategy.scala
---
@@ -70,7 +70,7 @@ import
org.apache.spark.mllib.tree.configuration.QuantileStrategy._
*/
@Experimental
class Strategy (
--- End diff --
This has been a long-standing problem, with several iterations of adding
new parameters. I agree with your suggested approach, but had stuck with the
old one for consistency. I'm OK with changing the API. Should we now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
