Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21748#discussion_r205986079
  
    --- Diff: 
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/ClientModeTestsSuite.scala
 ---
    @@ -0,0 +1,111 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.k8s.integrationtest
    +
    +import org.scalatest.concurrent.Eventually
    +import scala.collection.JavaConverters._
    +
    +import 
org.apache.spark.deploy.k8s.integrationtest.KubernetesSuite.{k8sTestTag, 
INTERVAL, TIMEOUT}
    +
    +trait ClientModeTestsSuite { k8sSuite: KubernetesSuite =>
    +
    +  test("Run in client mode.", k8sTestTag) {
    +    val labels = Map("spark-app-selector" -> driverPodName)
    +    val driverPort = 7077
    +    val blockManagerPort = 10000
    +    val driverService = testBackend
    +      .getKubernetesClient
    +      .services()
    +      .inNamespace(kubernetesTestComponents.namespace)
    +      .createNew()
    +        .withNewMetadata()
    +          .withName(s"$driverPodName-svc")
    +          .endMetadata()
    +        .withNewSpec()
    +          .withClusterIP("None")
    +          .withSelector(labels.asJava)
    +          .addNewPort()
    +            .withName("driver-port")
    +            .withPort(driverPort)
    +            .withNewTargetPort(driverPort)
    +            .endPort()
    +          .addNewPort()
    +            .withName("block-manager")
    +            .withPort(blockManagerPort)
    +            .withNewTargetPort(blockManagerPort)
    +            .endPort()
    +          .endSpec()
    +        .done()
    +    try {
    +      val driverPod = testBackend
    +        .getKubernetesClient
    +        .pods()
    +        .inNamespace(kubernetesTestComponents.namespace)
    +        .createNew()
    +          .withNewMetadata()
    +          .withName(driverPodName)
    +          .withLabels(labels.asJava)
    +          .endMetadata()
    +        .withNewSpec()
    +          .withServiceAccountName("default")
    --- End diff --
    
    I will create one.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to