Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21886#discussion_r206013525
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -529,9 +529,13 @@ abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
case logical.Distinct(child) =>
throw new IllegalStateException(
"logical distinct operator should have been replaced by
aggregate in the optimizer")
- case logical.Intersect(left, right) =>
+ case logical.Intersect(left, right, false) =>
throw new IllegalStateException(
- "logical intersect operator should have been replaced by
semi-join in the optimizer")
+ "logical intersect operator should have been replaced by
semi-join in the optimizer")
+ case logical.Intersect(left, right, true) =>
+ throw new IllegalStateException(
+ "logical intersect operator should have been replaced by union,
aggregate" +
--- End diff --
nit: looks we need a space for ` aggregate"` -> ` aggregate "`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
