Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21721#discussion_r206392487
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
    @@ -163,7 +163,8 @@ class SourceProgress protected[sql](
       val endOffset: String,
       val numInputRows: Long,
       val inputRowsPerSecond: Double,
    -  val processedRowsPerSecond: Double) extends Serializable {
    +  val processedRowsPerSecond: Double,
    +  val customMetrics: Option[JValue] = None) extends Serializable {
    --- End diff --
    
    @HyukjinKwon 
    Nice finding. I missed it while reviewing.
    
    Btw, FYI, in #21469 I'm adding new field with default value in 
StateOperatorProgress, like `val customMetrics: ju.Map[String, JLong] = new 
ju.HashMap()` and MiMa doesn't complain.
    
    
https://github.com/apache/spark/pull/21469/files#diff-e09301244e3c6b1a69eda6c4bd2ddb52
    
    @arunmahadevan 
    Maybe `ju.Map[String, JLong]` will also work here.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to