Github user maryannxue commented on the issue:

    https://github.com/apache/spark/pull/21699
  
    @MaxGekk LGTM, but one more thing to consider:
    Since we support column list in SQL, it would be nice to support it and 
test it in DataFrame pivot too. The only thing that we need to enable is to 
make pivot values `Expression`s instead of `Literal`s, coz `Literal`s do not 
include struct-type literals, e.g., `struct(1, 2)`. The `Pivot` node already 
has pivot values as `Seq[Expression]`, so all left to be done is in the 
DataFrame interfaces.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to