Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r206695469
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala
---
@@ -156,6 +160,14 @@ private[yarn] class YarnAllocator(
private[yarn] val containerPlacementStrategy =
new LocalityPreferredContainerPlacementStrategy(sparkConf, conf,
resource, resolver)
+ def createResourceCapability: Resource = {
--- End diff --
looks like this is only used to initialize `resource`, you could just
inline it. (at least should be `private`)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
