Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/21733#discussion_r206727984
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala
---
@@ -53,7 +53,35 @@ class StreamingAggregationSuite extends
StateStoreMetricsTest
import testImplicits._
- test("simple count, update mode") {
+ def executeFuncWithStateVersionSQLConf(
+ stateVersion: Int,
+ confPairs: Seq[(String, String)],
+ func: => Any): Unit = {
+ withSQLConf(confPairs ++
+ Seq(SQLConf.STREAMING_AGGREGATION_STATE_FORMAT_VERSION.key ->
stateVersion.toString): _*) {
+ func
+ }
+ }
+
+ def testWithAllStateVersions(name: String, confPairs: (String, String)*)
--- End diff --
super nit: the confPair param is used only in one location, do you think
its worth adding it as a param? The only test that needs it can stay unchanged.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
