Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21733#discussion_r206790470
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/MemoryStateStore.scala
 ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming.state
    +
    +import java.util.concurrent.ConcurrentHashMap
    +
    +import org.apache.spark.sql.catalyst.expressions.UnsafeRow
    +
    +class MemoryStateStore extends StateStore() {
    +  import scala.collection.JavaConverters._
    +  private val map = new ConcurrentHashMap[UnsafeRow, UnsafeRow]
    +
    +  override def iterator(): Iterator[UnsafeRowPair] = {
    +    map.entrySet.iterator.asScala.map { case e => new 
UnsafeRowPair(e.getKey, e.getValue) }
    +  }
    +
    +  override def get(key: UnsafeRow): UnsafeRow = map.get(key)
    +
    +  override def put(key: UnsafeRow, newValue: UnsafeRow): Unit = {
    +    map.put(key.copy(), newValue.copy())
    +  }
    +
    +  override def remove(key: UnsafeRow): Unit = {
    +    map.remove(key)
    --- End diff --
    
    Yeah missed that. Will fix.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to