Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/21943#discussion_r206982253 --- Diff: core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala --- @@ -252,6 +252,22 @@ private[spark] class TaskSchedulerImpl( } } + override def killAllTaskAttempts( + stageId: Int, + interruptThread: Boolean, + reason: String): Unit = synchronized { + logInfo(s"Killing all running tasks in stage $stageId: $reason") + taskSetsByStageIdAndAttempt.get(stageId).foreach { attempts => --- End diff -- This is some dup code and we dropped the useful comments from `cancelTasks`. It would be great if we move the common code here with comment and let cancelTasks call this method.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org