Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21957#discussion_r207155086
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -436,8 +436,9 @@ object DataSourceStrategy {
*
* @return a `Some[Filter]` if the input [[Expression]] is convertible,
otherwise a `None`.
*/
- protected[sql] def translateFilter(predicate: Expression):
Option[Filter] = {
- predicate match {
+ protected[sql] def translateFilter(predicate: Expression,
+ filterCast: Boolean = true):
Option[Filter] = {
--- End diff --
nit: style issue (you'd be better to check the style in other places again);
```
protected[sql] def translateFilter(
predicate: Expression,
filterCast: Boolean = true): Option[Filter] = {
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
