Github user sryza commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2968#discussion_r19931259
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala ---
    @@ -249,7 +248,7 @@ class HadoopRDD[K, V](
                 && bytesReadCallback.isDefined) {
               recordsSinceMetricsUpdate = 0
               val bytesReadFn = bytesReadCallback.get
    -          inputMetrics.bytesRead = bytesReadFn()
    +          context.taskMetrics.inputMetrics.get.bytesRead = bytesReadFn()
    --- End diff --
    
    This change is a followup from SPARK-2621 that @pwendell asked to include 
here.  Since there's not consensus on the best way to do this, and it's not 
really related to output metrics, I'm going to take this out. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to