Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21948#discussion_r207295461
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/ContinuousRateStreamSource.scala
 ---
    @@ -89,8 +89,7 @@ class RateStreamContinuousReader(options: 
DataSourceOptions) extends ContinuousR
             start.runTimeMs,
             i,
             numPartitions,
    -        perPartitionRate)
    -        .asInstanceOf[InputPartition[InternalRow]]
    +        perPartitionRate): InputPartition[InternalRow]
    --- End diff --
    
    This should be in a separate commit. I didn't notice yesterday that this is 
for the writer until it was linked from the other issue. I think this change 
needs to get in, but it should not be mixed into changes for the write path.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to