Github user jzhuge commented on the issue:

    https://github.com/apache/spark/pull/21911
  
    The new commit should have taken care of all review comments except the 
following:
    
    > Add an end-to-end test case.
    Which test suite is a good place to add such end-to-end case?
    
    > Add a unit test case by using Dataset.hint(name: String, parameters: 
String*)
    Found it not applicable after examining DataFrameHintSuite.”various hint 
parameters" .
    Do we plan to support such call as `df.hint("COALESCE", Seq(10))`? Why not 
just use `df.coalesce(10)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to