Github user dbtsai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21847#discussion_r207358817
  
    --- Diff: external/avro/src/test/resources/messy.avsc ---
    @@ -0,0 +1,140 @@
    +{
    --- End diff --
    
    Instead of adding this complicated avro json schema, should we test smaller 
cases as unit tests in `AvroCatalystDataConversionSuite` so in the future, it 
will be easier to know what is broken? Thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to