Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/21895#discussion_r207419217 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala --- @@ -80,8 +80,8 @@ import org.apache.spark.util.kvstore._ * break. Simple streaming of JSON-formatted events, as is implemented today, implicitly * maintains this invariant. */ -private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock) - extends ApplicationHistoryProvider with Logging { +private[history] class FsHistoryProvider(conf: SparkConf, protected val clock: Clock) + extends ApplicationHistoryProvider with LogFilesBlacklisting with Logging { --- End diff -- This seems not so necessary, let's inline this trait.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org