Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21975#discussion_r207459831
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
 ---
    @@ -539,11 +539,10 @@ object ParquetFileFormat extends Logging {
           parFiles.flatMap { currentFile =>
             try {
               // Skips row group information since we only need the schema.
    -          // ParquetFileReader.readFooter throws RuntimeException, instead 
of IOException,
    +          // ParquetUtils.readFooter throws RuntimeException, instead of 
IOException,
               // when it can't read the footer.
               Some(new Footer(currentFile.getPath(),
    --- End diff --
    
    Seems it can't replace this here for now since it looks causing resource 
leak. I filed a JIRA https://issues.apache.org/jira/browse/PARQUET-1368


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to