Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/21860#discussion_r207809333
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
---
@@ -232,6 +232,23 @@ class WholeStageCodegenSuite extends QueryTest with
SharedSQLContext {
}
}
+ test("SPARK-24901 check merge FastHashMap and RegularHashMap generate
code max size") {
+ val caseNumber = 80
+ // merge fastHashMap and regularHashMap generate code max size
+ val codeWithLongFunctions = genGroupByCode(caseNumber)
+ val (_, maxCodeSize) = CodeGenerator.compile(codeWithLongFunctions)
+ assert(maxCodeSize < 13500)
--- End diff --
What does `13500` means? The current max code size?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
