Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/22009#discussion_r208380139
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceRDD.scala
---
@@ -51,18 +58,19 @@ class DataSourceRDD[T: ClassTag](
valuePrepared
}
- override def next(): T = {
+ override def next(): Any = {
if (!hasNext) {
throw new java.util.NoSuchElementException("End of stream")
}
valuePrepared = false
reader.get()
}
}
- new InterruptibleIterator(context, iter)
+ // TODO: get rid of this type hack.
+ new InterruptibleIterator(context,
iter.asInstanceOf[Iterator[InternalRow]])
--- End diff --
Why is this necessary? I think the TODO should be handled in this commit
and that Spark shouldn't cast RDD[ColumnarBatch] to RDD[InternalRow].
What about having the RDD iterate over the rows in the batch to actually
implement the interface? It can provide the underlying batches through a
different API.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
