Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22032#discussion_r208637385
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/LSH.scala ---
    @@ -97,7 +97,8 @@ private[ml] abstract class LSHModel[T <: LSHModel[T]]
     
       override def transform(dataset: Dataset[_]): DataFrame = {
         transformSchema(dataset.schema, logging = true)
    -    val transformUDF = udf(hashFunction, DataTypes.createArrayType(new 
VectorUDT))
    +    val transformUDF = udf({ v: Vector => hashFunction(v) },
    --- End diff --
    
    not really, you had `hashFunction(_)` which doesn't work. `hashFunction(_: 
Vector)` or `hashFunction _` should work instead.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to