Github user lindblombr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21847#discussion_r208770874
  
    --- Diff: 
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala ---
    @@ -78,6 +79,25 @@ class AvroSuite extends QueryTest with SharedSQLContext 
with SQLTestUtils {
         checkAnswer(newEntries, originalEntries)
       }
     
    +  def checkAvroSchemaEquals(avroSchema: String, expectedAvroSchema: 
String): Unit = {
    +    assert(new Schema.Parser().parse(avroSchema) ==
    +      new Schema.Parser().parse(expectedAvroSchema))
    +  }
    +
    +  def getAvroSchemaStringFromFiles(filePath: String): String = {
    --- End diff --
    
    Should we update the test L980 `"Validate namespace in avro file that has 
nested records with the same name"` to use this, too?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to