Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/22017#discussion_r208868838
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -225,7 +264,9 @@ trait ExpressionEvalHelper extends
GeneratorDrivenPropertyChecks with PlanTestBa
val lit = InternalRow(expected, expected)
val expectedRow =
UnsafeProjection.create(Array(expression.dataType,
expression.dataType)).apply(lit)
- if (unsafeRow != expectedRow) {
+ val field = StructField("field", expression.dataType)
+ val dataType = StructType(field :: field :: Nil)
+ if (!checkResult(unsafeRow, expectedRow, dataType)) {
--- End diff --
```UnsafeRow```s are compared based on equality of backing arrays. This
approach doesn't work well when ignoring order in unsafe representation of maps.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
