Github user vackosar commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21919#discussion_r208902692
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/streaming/progress.scala ---
    @@ -213,6 +216,12 @@ class SinkProgress protected[sql](
       override def toString: String = prettyJson
     
       private[sql] def jsonValue: JValue = {
    -    ("description" -> JString(description))
    +    ("description" -> JString(description)) ~
    +      ("numOutputRows" -> JInt(numOutputRows))
       }
     }
    +
    +object SinkProgress {
    +  def apply(description: String, numOutputRows: Option[Long]): 
SinkProgress =
    +      new SinkProgress(description, numOutputRows.getOrElse(-1L))
    --- End diff --
    
    It would be good to impl indentation rules into the scalastyle-config.xml. 
Not sure how, but could look into that in future.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to