Github user jose-torres commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22009#discussion_r208763503
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/SessionConfigSupport.java
 ---
    @@ -27,10 +27,10 @@
     @InterfaceStability.Evolving
     public interface SessionConfigSupport extends DataSourceV2 {
     
    -    /**
    -     * Key prefix of the session configs to propagate. Spark will extract 
all session configs that
    -     * starts with `spark.datasource.$keyPrefix`, turn 
`spark.datasource.$keyPrefix.xxx -> yyy`
    -     * into `xxx -> yyy`, and propagate them to all data source 
operations in this session.
    -     */
    -    String keyPrefix();
    +  /**
    +   * Key prefix of the session configs to propagate. Spark will extract 
all session configs that
    +   * starts with `spark.datasource.$keyPrefix`, turn 
`spark.datasource.$keyPrefix.xxx -> yyy`
    --- End diff --
    
    Is `datasource` a placeholder here, or would Kafka configs now be e.g. 
`spark.datasource.kafka.[...]`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to