Github user yucai commented on a diff in the pull request: https://github.com/apache/spark/pull/22066#discussion_r209265323 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala --- @@ -2831,4 +2831,17 @@ class SQLQuerySuite extends QueryTest with SharedSQLContext { } } } + + test("SPARK-25084: 'distribute by' on multiple columns may lead to codegen issue") { + withView("spark_25084") { + val count = 1000 --- End diff -- How to inline? We still use it in the assert. ``` assert( spark.sql(s"select * from spark_25084 distribute by ($distributeExprs)").count() === count) ```
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org