Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21977#discussion_r209330276
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -91,6 +91,13 @@ private[spark] class Client(
private val executorMemoryOverhead =
sparkConf.get(EXECUTOR_MEMORY_OVERHEAD).getOrElse(
math.max((MEMORY_OVERHEAD_FACTOR * executorMemory).toLong,
MEMORY_OVERHEAD_MIN)).toInt
+ private val isPython = sparkConf.get(IS_PYTHON_APP)
--- End diff --
This is interesting, my one concern here is probably a little esoteric, for
mixed language pipelines this might not behave as desired. I'd suggest maybe a
JIRA and a note in the config param that it only applies to Python apps not
mixed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
