GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/22075
[SPARK-23908][SQL][FOLLOW-UP] Rename inputs to arguments, and add argument
type check.
## What changes were proposed in this pull request?
This is a follow-up pr of #21954 to address comments.
- Rename ambiguous name `inputs` to `arguments`.
- Add argument type check and remove hacky workaround.
- Address other small comments.
## How was this patch tested?
Existing tests and some additional tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark issues/SPARK-23908/fup1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22075.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22075
----
commit d2bf2be8c244910dbc2fc066f8c73212208ffe01
Author: Takuya UESHIN <ueshin@...>
Date: 2018-08-11T04:52:59Z
Rename inputs to arguments.
commit 1ece98baeb5415b975995e1a1626dd90101dd64a
Author: Takuya UESHIN <ueshin@...>
Date: 2018-08-11T04:54:18Z
Rename partialArguments to argInfo.
commit fb23aba7e3e5bb4eef2f3927212190b6507cbd65
Author: Takuya UESHIN <ueshin@...>
Date: 2018-08-11T06:20:55Z
Add argument data type check.
commit 3ccd995e8a1260205fea5db63c40c644499a5e01
Author: Takuya UESHIN <ueshin@...>
Date: 2018-08-11T04:34:13Z
Address other comments.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
