Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/21561#discussion_r209541917 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala --- @@ -151,13 +152,9 @@ class BisectingKMeans private ( this } - /** - * Runs the bisecting k-means algorithm. - * @param input RDD of vectors - * @return model for the bisecting kmeans - */ - @Since("1.6.0") - def run(input: RDD[Vector]): BisectingKMeansModel = { + + private[spark] def run(input: RDD[Vector], + instr: Option[Instrumentation]): BisectingKMeansModel = { --- End diff -- nit: indentation
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org