Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22071#discussion_r209633119
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcher.scala
 ---
    @@ -51,6 +51,13 @@ private[mesos] class MesosClusterDispatcher(
         conf: SparkConf)
       extends Logging {
     
    +  {
    +    val authKey = SecurityManager.SPARK_AUTH_SECRET_CONF
    --- End diff --
    
    I thought about this too, and originally wrote it that way ... but then I 
figured the way it works now, its really the same thing.  If I put it in the 
MesosRestServer, it might seem like you could run the ClusterDispatcher without 
the RestServer somehow -- but maybe the exception itself is clear enough?
    
    anyway, don't feel particularly strongly either way.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to