Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20611#discussion_r209646119
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -1976,6 +1976,56 @@ private[spark] object Utils extends Logging {
         }
       }
     
    +  /**
    +   * Returns a qualified path object.
    +   * @param defaultUri default uri corresponding to the filesystem 
provided.
    +   * @param workingDir the working directory for the particular child path 
wd-relative names.
    +   * @param path Path instance based on the path string specified by the 
user.
    +   * @return Returns a qualified path object
    +   */
    +  def makeQualified(defaultUri: URI, workingDir: Path, path: Path): Path = 
{
    --- End diff --
    
    If this is 'ported' from a Hadoop API method, it's good to note that inside 
the method as a comment, at least.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to