Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22017#discussion_r209820737
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -2238,6 +2238,70 @@ class DataFrameFunctionsSuite extends QueryTest with 
SharedSQLContext {
         assert(ex5.getMessage.contains("cannot resolve '`a`'"))
       }
     
    +  test("map_zip_with function - map of primitive types") {
    +    val df = Seq(
    +      (Map(8 -> 6L, 3 -> 5L, 6 -> 2L), Map[Integer, Integer]((6, 4), (8, 
2), (3, 2))),
    +      (Map(10 -> 6L, 8 -> 3L), Map[Integer, Integer]((8, 4), (4, null))),
    +      (Map.empty[Int, Long], Map[Integer, Integer]((5, 1))),
    +      (Map(5 -> 1L), null)
    +    ).toDF("m1", "m2")
    +
    +    checkAnswer(df.selectExpr("map_zip_with(m1, m2, (k, v1, v2) -> k == v1 
+ v2)"),
    +      Seq(
    +        Row(Map(8 -> true, 3 -> false, 6 -> true)),
    +        Row(Map(10 -> null, 8 -> false, 4 -> null)),
    +        Row(Map(5 -> null)),
    +        Row(null)))
    +  }
    +
    +  test("map_zip_with function - map of complex types") {
    --- End diff --
    
    nit: `non-primitive` instead of `complex`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to