Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22101#discussion_r209855589
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/execution/RecordBinaryComparator.java
 ---
    @@ -60,7 +60,7 @@ public int compare(
         while (i < leftLen) {
           res = (Platform.getByte(leftObj, leftOff + i) & 0xff) -
                   (Platform.getByte(rightObj, rightOff + i) & 0xff);
    -      if (res != 0) return res;
    +      if (res != 0) return (int) res;
    --- End diff --
    
    ditto


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to