GitHub user mgaido91 opened a pull request:

    https://github.com/apache/spark/pull/22102

    [SPARK-25051][SQL] FixNullability should not stop on AnalysisBarrier

    ## What changes were proposed in this pull request?
    
    The introduction of `AnalysisBarrier` prevented `FixNullability` to go 
through all the nodes. This introduced a bug, which can lead to wrong results, 
as the nullability of the output attributes of an outer join can be wrong.
    
    The PR makes `FixNullability` going through the `AnalysisBarrier`s.
    
    ## How was this patch tested?
    
    added UT


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgaido91/spark SPARK-25051

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22102.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22102
    
----
commit 043a8ad82678f2b2f12397377890232d7884963d
Author: Marco Gaido <marcogaido91@...>
Date:   2018-08-14T09:31:12Z

    [SPARK-25051][SQL] FixNullability should not stop on AnalysisBarrier

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to