Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21835#discussion_r210489980
--- Diff: R/pkg/R/functions.R ---
@@ -3320,7 +3321,7 @@ setMethod("explode",
#' @aliases sequence sequence,Column-method
#' @note sequence since 2.4.0
setMethod("sequence",
- signature(x = "Column", y = "Column"),
+ signature(),
--- End diff --
sorry, I didn't see the reply.
yes, we should try to make sequence callable.
we shouldn't have to manually call it though and it is better to rely on R
internal type/call routing. it's a bit hard to explain but check out
`attach` `setGeneric("attach")`
or
`str` `setGeneric("str")`
if you see what I mean.
also we should avoid `signature()` empty as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
