Github user kiszk commented on the issue:
https://github.com/apache/spark/pull/21537
Thank for involving me in an important thread. I was busy this morning in
Japan.
I think there are three topics in the thread.
1. Merge or revert this PR
2. Design document
3. IR design
For 1., in short, my opinion is likely to revert this PR from the view like
a release manager.
As we know, it is a time to cut a release branch. This PR partially
introduce a new representation. If there would be a bug in code generation at
Spark 2.4, it may introduce a complication of debugging and fixing.
As @mgaido91 pointed out, #20043 and #21026 have been merged. I think that
they are a kind of refactoring (e.g. change the representation of literal,
class, and so on). Thus, these two PRs can be there. However, this PR
introduces a mixture of representation `s""` and `code""`.
WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
